-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular app adaptation fails #850
Comments
Hey @0xAnakin , can you try to use the new I tested it yesterday for this version of
You can check If for some reason you need to keep using the old stack (yeoman generator) I think you are experiencing the same problem(s) listed here -> #613 |
Hey @izaera I had no idea you had a new tool out 😮. I tried with a new sample angular app and I get the following error about a |
I created a {
"liferayDir": "C:/Development/liferay/liferay-dxp-7.3.10.1-sp1-ethniki"
} Then I tried I assume that:
|
Yep. That one was working, so it probably broke with the last update :-(.
Not so sure about that. I know it did that in previous versions of the JS Toolkit, and I know it's handy, but on the other side, building usually tooks very long and it isn't always needed before deployment... 🤔 We may unify those targets again in the future, when we optimize the build times, but for now, I feel it is better to separate them... In any case, I'd like to hear more opinions on this, so I'm mentioning some more people to see what they think: @bryceosterhaus @pablo-agulla @dsanz @kresimir-coko |
bump |
This is handy yeah, but at the same time, forces a build for each deployment, so if you want to deploy to more than one target, that will slow down things. Couldn't this be somehow configurable with a sensible default? For simple use cases it may make sense to tie both tasks. Maybe having a separate entry under |
I like the idea of having two entries on the package.json 👍 How about:
Or is it better to have the opposite? 🤔 :
|
For me it's more clear the second option, however if in the portal, deploy always builds & deploys, I'll go for option 1 |
Hey, I'm not going to release a new version specifically for this, but if you need it @0xAnakin just ask for it. |
Tried to adapt an angular app and it failed firstly when using npm as a dependency manager see #848 and after that when trying to locate the path
build/static/js
which does not exist in an out of the box angular app. Use the exact node version mentioned below and npm as a package manager. See reproduction steps listed at the end.node version
packages installed globally
├── @angular/[email protected]
├── [email protected]
├── [email protected]
├── [email protected]
└── [email protected]
Steps
npm install -g yo generator-liferay-js @angular/cli
ng new angular-app
cd angular-app
yo liferay-js:adapt
The text was updated successfully, but these errors were encountered: