From 576695cbf5b6d4f1c7cc0dae323ce578abb0e262 Mon Sep 17 00:00:00 2001 From: Jonah Miller Date: Thu, 30 Nov 2023 09:32:18 -0700 Subject: [PATCH] add tests constraint --- .github/PULL_REQUEST_TEMPLATE.md | 1 + doc/sphinx/src/contributing.rst | 7 +++++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 5b01428c29..e57889c82f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -18,6 +18,7 @@ detail. Why is this change required? What problem does it solve?--> - [ ] Document any new features, update documentation for changes made. - [ ] Make sure the copyright notice on any files you modified is up to date. - [ ] After creating a pull request, note it in the CHANGELOG.md file. +- [ ] LANL employees: make sure tests pass both on the github CI and on the Darwin CI If preparing for a new release, in addition please check the following: - [ ] Update the version in cmake. diff --git a/doc/sphinx/src/contributing.rst b/doc/sphinx/src/contributing.rst index b6e20cca1b..97e637e6d0 100644 --- a/doc/sphinx/src/contributing.rst +++ b/doc/sphinx/src/contributing.rst @@ -710,14 +710,17 @@ version number in the ``project`` field of the of the top-level ``CHANGELOG.md``, moving all the changes listed under ``Current Main`` to that release. Then add empty categories for ``Current Main``. Typically the branch for this merge request should be called -``v[release number]-rc`` for "release candidate." +``v[release number]-rc`` for "release candidate." Make sure that the +full test suite passes for this PR. After that pull request is merged, go to the ``releases`` tab on the right sidebar on github, and draft a new release. Set the tag to ``v[release number]``, fill the comment with the changes in the changelog since the last release, and make the release. -Finally, the Spackages must be updated. To do so, you will need the checksum for the tarball for the newest release. Download the tarball from the release page, and then run +Finally, the Spackages must be updated. To do so, you will need the +checksum for the tarball for the newest release. Download the tarball +from the release page, and then run .. code-block:: bash