-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for PHP 8.4 #98
base: 3.15.x
Are you sure you want to change the base?
Conversation
Signed-off-by: tux-rampage <[email protected]>
Interesting, the tooling used in the GitHub actions seems to be a bit out of date. They use 8.4.0RC4 and the composer.phar throws implicit null Notices. Locally a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to ignore platform reqs on 8.4 to get dependencies installed: https://github.com/laminas/laminas-filter/pull/181/files
I think the CI matrix action will need a new release to use the 8.4 GA release, but the RC should be fine for the time being.
Most risky/truthy Psalm issues can be solved by changing conditionals from if (! $thing)
to if ($thing !== null)
or $this->thing = $thing ?? 'default'
, or revert the lockfile and composer update nothing
so the psalm issues can be dealt with in a separate patch maybe
Thanks for the Tipp. Will check this.
This check is failing for a while, but addressing it here would be out of scope and require a separate PR. |
Signed-off-by: tux-rampage <[email protected]>
PHPUnit for It seems to be the lowest allowed PHPUnit version. Can we raise it to |
Yeah - do what you want with dev deps. I always run You may also need to bump |
Description
This will add support for PHP 8.4