Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return types to test class methods #4

Open
1 of 2 tasks
weierophinney opened this issue Dec 31, 2019 · 2 comments
Open
1 of 2 tasks

Add return types to test class methods #4

weierophinney opened this issue Dec 31, 2019 · 2 comments

Comments

@weierophinney
Copy link
Member

It seems methods of Test-Classes should have return types, this is not the case within this project.
The TODO would be to add these return types.

Missing information

  • Is there a commitment, rfc or discussion to refer to?
  • Link to the originating PR

Originally posted by @tux-rampage at zendframework/zend-di#40

@tux-rampage
Copy link
Member

This will become a requirement when upgrading to PHPUnit 9

@tux-rampage
Copy link
Member

This is part of the CS. The auto-fixer of phpcs added these in #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants