Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alphabetical order of en.toml translation IDs #49409

Open
apoorvapendse opened this issue Jan 13, 2025 · 3 comments · May be fixed by #49412 or #49439
Open

Fix alphabetical order of en.toml translation IDs #49409

apoorvapendse opened this issue Jan 13, 2025 · 3 comments · May be fixed by #49412 or #49439
Assignees
@apoorvapendse
Labels
area/localization General issues or PRs related to localization kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@apoorvapendse
Copy link
Contributor

This is a Bug Report

Problem: Need to fix the alphabetical order for blog_post_show_more and banner_acknowledgement translation IDs in en.toml.
Originally discussed in this PR.
In this review comment.

Creating a new issue as recommended by @shurup here.

Proposed Solution:
Update the placement of the translation IDs mentioned as per the alphabetical order.
@apoorvapendse apoorvapendse added the kind/bug Categorizes issue or PR as related to a bug. label Jan 13, 2025
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 13, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@apoorvapendse apoorvapendse mentioned this issue Jan 13, 2025
Merged
@sftim
Copy link
Contributor

sftim commented Jan 13, 2025

/area localization
/language en

@k8s-ci-robot k8s-ci-robot added area/localization General issues or PRs related to localization language/en Issues or PRs related to English language labels Jan 13, 2025
@aakankshabhende aakankshabhende linked a pull request Jan 13, 2025 that will close this issue
Open
@apoorvapendse
Copy link
Contributor Author

/assign

apoorvapendse added a commit to apoorvapendse/website that referenced this issue Jan 15, 2025
@apoorvapendse
i18n: Fix alphabetical order of translation IDs.
8225f49 
Fixes kubernetes#49409.

Signed-off-by: Apoorva Pendse <[email protected]>
@apoorvapendse apoorvapendse linked a pull request Jan 15, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apoorvapendse apoorvapendse

Labels
area/localization General issues or PRs related to localization kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Milestone
No milestone
3 participants
@k8s-ci-robot @sftim @apoorvapendse