You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Various PRs often make changes that affect proto generated go/python libraries. It is often the case that folks forget to regenerated the relevant packages/modules, and they end up getting caught in the release generation scripts: #11531
We should add CI that will fail validation if the generated libraries produce diffs in PRs, if they do the author will need to regenerate and include this as part of their PR.
Labels
/area backend
Love this idea? Give it a 👍.
The text was updated successfully, but these errors were encountered:
@HumairAK I was thinking that we could first run the make command to generate protos and check for diff using something like 'git diff' , If the user has not added the generated files this should generate a diff in the workflow run then we can directly fail the job with a diff message . Is this the correct approach ?
@HumairAK I was thinking that we could first run the make command to generate protos and check for diff using something like 'git diff' , If the user has not added the generated files this should generate a diff in the workflow run then we can directly fail the job with a diff message . Is this the correct approach ?
This sounds good to me @chahatsagarmain! Thanks for volunteering to take this on.
Chore description
Various PRs often make changes that affect proto generated go/python libraries. It is often the case that folks forget to regenerated the relevant packages/modules, and they end up getting caught in the release generation scripts: #11531
We should add CI that will fail validation if the generated libraries produce diffs in PRs, if they do the author will need to regenerate and include this as part of their PR.
Labels
/area backend
Love this idea? Give it a 👍.
The text was updated successfully, but these errors were encountered: