Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing license information for Emboss.ts #1375

Open
kswartz26 opened this issue Jul 28, 2022 · 2 comments
Open

Missing license information for Emboss.ts #1375

kswartz26 opened this issue Jul 28, 2022 · 2 comments

Comments

@kswartz26
Copy link

The comment headers point to http://www.pixastic.com/lib/license.txt for the license, but that URL no longer resolves.

Looking it up on the Internet Archive, it appears this code is licensed under the Mozilla Public License. This is quite different and less permissive than the MIT license for the top-level project, and should be explicitly called out, either in the top-level LICENSE file, a separate NOTICE file, or by correcting the information in Emboss.ts. It is otherwise very easy to inadvertently violate the terms of that license, as most developers would expect it to also be under an MIT license.

@lavrton
Copy link
Member

lavrton commented Jul 30, 2022

That is a good point. Can you make a Pull Request for that? I think mentioning in LICENSE file should be simpler.

I am thinking if we should just remove that filter and couple others. I feel like almost nobody is using that filter.

Just curios, how did you find it? Were you strictly checking all licenses in files?

@kswartz26
Copy link
Author

I can do a pull request, although if you're going to remove the filter altogether, there's not much point. :)

Although it's probably a good idea to deprecate it for a while first.

Yes, I was checking for additional copyrights and licenses when I came across it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants