Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As an observer of the map I'd like to see the offline region prims #5

Open
kf6kjg opened this issue Jan 9, 2017 · 1 comment
Open

Comments

@kf6kjg
Copy link
Owner

kf6kjg commented Jan 9, 2017

Currently the offline regions are rendered with a fixed solid color. This could be changed to simply do a post-process on the rendered tile: set the hue to a specific color, put in an overlay image, something like that.

@kf6kjg
Copy link
Owner Author

kf6kjg commented Jul 11, 2017

There's a note in the code near line 358 of RDBMap.cs, committed in 6211bc:

if (!region.HasKnownCoordinates()) {
	// Hey, the region is KNOWN to not have any clue as to where it is located.  Skippage.

	// ISSUE: since the region location info is pulled from disk sometime much later this will result in offline regions that don't have their prim data.
	// Not an issue ATM, but at some point offline with prims will be wanted.

	continue;
}

This is because the location information for the region at hand might be pulled up from disk some time later, but since it's not known at this point the region doesn't get any prims assigned to it. RDBMap needs some serious refactoring anyway, so maybe this will go away at some point.

@kf6kjg kf6kjg added this to the 2.4 Drawing Enhancements milestone Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant