Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LuraToons: update of the webview display and code organization #6548

Closed
wants to merge 4 commits into from

Conversation

Hellkaros
Copy link
Contributor

@Hellkaros Hellkaros commented Dec 9, 2024

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension

@Hellkaros Hellkaros changed the title LuraToons: update of the webview display and code organization [https://github.com/keiyoushi/extensions-source/issues/6468](#6468) LuraToons: update of the webview display and code organization Dec 9, 2024
@Hellkaros
Copy link
Contributor Author

Hellkaros commented Dec 9, 2024

Some of the issues have been resolved (#6468)

@Hellkaros Hellkaros changed the title LuraToons: update of the webview display and code organization LuraToons: update of the webview display and code organization [#6468](https://github.com/keiyoushi/extensions-source/issues/6468) Dec 9, 2024
@Hellkaros Hellkaros changed the title LuraToons: update of the webview display and code organization [#6468](https://github.com/keiyoushi/extensions-source/issues/6468) LuraToons: update of the webview display and code organization Dec 9, 2024
@Smol-Ame
Copy link
Contributor

Smol-Ame commented Dec 9, 2024

  • Reference the relevant issues (that this PR will close/resolve) in the PR's description with "Closes #" instead, so it links properly
  • In general, just as a reminder, you should make a branch first & do the changes there, rather than using the main branch

@Hellkaros Hellkaros requested a review from bapeey December 10, 2024 13:05
Comment on lines -131 to +175
setUrlWithoutDomain("/api/obra/$mangaUrl/$capSlug")
url = "$mangaUrl/$capSlug"
Copy link
Contributor

@bapeey bapeey Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't work unless you create the API call in pageListRequest. Has this been properly tested?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, all page requests will be made through pageListRequest in the future. They changed the code, and everything is obfuscated, which is making it difficult to adjust. This PR was made to fix the webview of the work so that readers at least have something to read. I created a debug APK, and it’s working fine, except for the pages that still aren’t functioning.

@AnonymousPtBr
Copy link

👍

@Hellkaros Hellkaros closed this Dec 10, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants