-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LuraToons: update of the webview display and code organization #6548
Conversation
Some of the issues have been resolved (#6468) |
|
src/pt/randomscan/src/eu/kanade/tachiyomi/extension/pt/randomscan/LuraToon.kt
Show resolved
Hide resolved
src/pt/randomscan/src/eu/kanade/tachiyomi/extension/pt/randomscan/LuraToon.kt
Outdated
Show resolved
Hide resolved
src/pt/randomscan/src/eu/kanade/tachiyomi/extension/pt/randomscan/MangaDTO.kt
Outdated
Show resolved
Hide resolved
src/pt/randomscan/src/eu/kanade/tachiyomi/extension/pt/randomscan/LuraToon.kt
Outdated
Show resolved
Hide resolved
setUrlWithoutDomain("/api/obra/$mangaUrl/$capSlug") | ||
url = "$mangaUrl/$capSlug" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't work unless you create the API call in pageListRequest
. Has this been properly tested?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, all page requests will be made through pageListRequest in the future. They changed the code, and everything is obfuscated, which is making it difficult to adjust. This PR was made to fix the webview of the work so that readers at least have something to read. I created a debug APK, and it’s working fine, except for the pages that still aren’t functioning.
👍 |
Checklist:
extVersionCode
value inbuild.gradle
for individual extensionsoverrideVersionCode
orbaseVersionCode
as needed for all multisrc extensionsisNsfw = true
flag inbuild.gradle
when appropriateid
if a source's name or language were changedweb_hi_res_512.png
when adding a new extension