Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if database contains invalid Base64 represented dates #11578

Open
Paul-kp opened this issue Dec 19, 2024 · 5 comments
Open

Warn if database contains invalid Base64 represented dates #11578

Paul-kp opened this issue Dec 19, 2024 · 5 comments
Assignees

Comments

@Paul-kp
Copy link

Paul-kp commented Dec 19, 2024

XC will open a database that contains invalid data in a time value, without reporting the error.
It would be better to advise the user that there is an issue instead of ignoring it.
See this KeePass issue: entry not a valid Base-64 string

cheers, Paul

@droidmonkey
Copy link
Member

Is your desired action to prevent loading the database? What would the user do about the information the base64 is incorrect? Ignoring it and making it a correct base64 on save is the current behavior and, imo, the best behavior. Date time being incorrect is a very minor error and should not prevent loading of the database.

@Paul-kp
Copy link
Author

Paul-kp commented Dec 19, 2024

Agree that preventing loading is not ideal - this is the KeePass action.
Reporting the error to the user would allow them to find the offending app (and stop using it).
Repairing it is sensible, but some user interaction may be useful if it's a user configurable time.

cheers, Paul

@droidmonkey
Copy link
Member

Time isn't user configurable. It gets updated when an entry is modified or created. I think a console warning is more than sufficient in this case.

@droidmonkey droidmonkey self-assigned this Dec 20, 2024
@b23prodtm

This comment has been minimized.

@droidmonkey
Copy link
Member

None of this is related to KeePassXC.

@droidmonkey droidmonkey changed the title Database corruption not detected/reported (entry not a valid Base-64 string error in KeePass) Warn if database contains invalid Base64 represented dates Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants