Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use click choice options to simplify validation of project creation workflow #3878

Open
ankatiyar opened this issue May 20, 2024 · 0 comments · May be fixed by #4387
Open

Use click choice options to simplify validation of project creation workflow #3878

ankatiyar opened this issue May 20, 2024 · 0 comments · May be fixed by #4387
Assignees
Labels
Component: CLI Issue/PR that addresses the CLI for Kedro
Milestone

Comments

@ankatiyar
Copy link
Contributor

Description

Going through the click documentation, I came across these features -

These could be used to get rid of/simplify the validation we do for inputs to kedro new options like --tools and --example.

Context

The project creation workflow is a little complicated, some values come from the CLI command and some from the cookiecutter prompts

Possible Implementation

  • Could use click functionalities to get rid of some of the custom validation we do for inputs using regex etc
  • Could explore if click prompts allow us to replace the cookiecutter prompts (related Make rich optional / not a core dependency of kedro #2928 cc @lrcouto)
  • There might be other CLI options that we're accepting as strings and validating (haven't checked) that could benefit from inbuild click features
@ankatiyar ankatiyar added Issue: Feature Request New feature or improvement to existing feature Component: CLI Issue/PR that addresses the CLI for Kedro labels May 20, 2024
@merelcht merelcht removed the Issue: Feature Request New feature or improvement to existing feature label Oct 7, 2024
@merelcht merelcht added this to the Tech debt milestone Oct 7, 2024
@merelcht merelcht moved this to To Do in Kedro Framework Nov 26, 2024
@lrcouto lrcouto self-assigned this Dec 9, 2024
@lrcouto lrcouto moved this from To Do to In Progress in Kedro Framework Dec 9, 2024
@lrcouto lrcouto linked a pull request Dec 17, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: CLI Issue/PR that addresses the CLI for Kedro
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

3 participants