Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Developing a model to create Correlation Heatmap #2323

Closed
wants to merge 3 commits into from

Conversation

rittikadeb
Copy link

Fixes

This PR resolves #2303

What does this PR do?

Developed a model to create a Correlation Heatmap.

Screenshots

image

@rittikadeb rittikadeb requested a review from FlorentLvr October 16, 2023 19:49
@FlorentLvr FlorentLvr requested review from srini047 and removed request for FlorentLvr October 17, 2023 08:10
@FlorentLvr FlorentLvr added good first issue Good for newcomers hacktoberfest Issues for hacktoberfest labels Oct 17, 2023
Copy link
Member

@srini047 srini047 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

@rittikadeb
Copy link
Author

Should I merge the pull request?

@FlorentLvr
Copy link
Contributor

@rittikadeb, thank you for your contribution. I have started reviewing your template. While it is working, there are a few areas that need to be reworked to ensure the template is as simple as possible.

Here are the specific changes I would like you to make:

  • Input Section: Currently, there is a cell called "Setup variables" in the input section. However, I expected to have the ability to set these variables in the cell below. Please update the template to allow for variable input in the appropriate cell.

  • Model Section: There is no markdown in the model section to explain what the code is doing. Please add a clear explanation of the code's purpose to help users understand its functionality. Additionally, I would like users to be able to create the chart in this section. Please include the code for chart creation here.

  • Output Section: I expect to see the graph and have the ability to create an HTML or PNG file that can be used outside of Naas. Please ensure that the graph is displayed in this section and provide the necessary code to export it as an HTML or PNG file.

Once you have made these changes, I will be happy to review and merge the template.

You can refer to the "Matplotlib - Create barchart" template as an example. If you need further guidance, please consult the readme, which provides a comprehensive explanation of the framework.

Feel free to reach out if you have any questions. Thank you! 🙏

image

@FlorentLvr FlorentLvr self-requested a review October 17, 2023 19:12
Copy link
Contributor

@FlorentLvr FlorentLvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are the specific changes I would like you to make:

Input Section: Currently, there is a cell called "Setup variables" in the input section. However, I expected to have the ability to set these variables in the cell below. Please update the template to allow for variable input in the appropriate cell.

Model Section: There is no markdown in the model section to explain what the code is doing. Please add a clear explanation of the code's purpose to help users understand its functionality. Additionally, I would like users to be able to create the chart in this section. Please include the code for chart creation here.

Output Section: I expect to see the graph and have the ability to create an HTML or PNG file that can be used outside of Naas. Please ensure that the graph is displayed in this section and provide the necessary code to export it as an HTML or PNG file.

@FlorentLvr FlorentLvr requested a review from srini047 October 17, 2023 19:13
@rittikadeb
Copy link
Author

Hey, I am having problem in pushing committed changes as I have forgotten my token!

@FlorentLvr
Copy link
Contributor

Hey, I am having problem in pushing committed changes as I have forgotten my token!

@rittikadeb
You can remove the old one and generate a new! Don't forget to pull the branch to get the last changes 🙏

@rittikadeb
Copy link
Author

Still I am having some issues. I will close this PR and open another one. Thanks!

@rittikadeb rittikadeb closed this Oct 18, 2023
@FlorentLvr FlorentLvr deleted the correlation-heatmap branch November 21, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Issues for hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Matplotlib - Correlation Heatmap
3 participants