Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications occur at inaccurate times #14

Open
stelcodes opened this issue May 18, 2023 · 1 comment · May be fixed by #15
Open

Notifications occur at inaccurate times #14

stelcodes opened this issue May 18, 2023 · 1 comment · May be fixed by #15

Comments

@stelcodes
Copy link
Contributor

stelcodes commented May 18, 2023 •
edited
Loading

pomo notify sends notifications at the wrong time occasionally. Reproduction:

export WORK_TIME=3
export BREAK_TIME=1
pomo notify &
pomo start
# Wait 3 minutes...
# notify job sends proper break start notification
pomo start
# Wait about 1 minute...
# notify job sends inaccurate work start notification with 2 minutes left in work cycle
@stelcodes stelcodes linked a pull request May 18, 2023 that will close this issue
Open
@stelcodes
Copy link
Contributor Author

stelcodes commented May 18, 2023 •
edited
Loading

After looking at the tests, I see that this is intended behavior to send a "best effort" notification even if it very delayed. I personally prefer to just skip the notification if it is late.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix inaccurate notifications issue stelcodes/pomo
1 participant
@stelcodes