Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How can I contribute? #120

Open
regisin opened this issue Oct 21, 2023 · 2 comments
Open

How can I contribute? #120

regisin opened this issue Oct 21, 2023 · 2 comments

Comments

@regisin
Copy link

regisin commented Oct 21, 2023

I created an AudioField type, AudioValidator, some exceptions, and corresponding tests. But my fork branch is failing, and I don't know why (fails on Lint)! Can I make a PR even though it fails?

Or is there any guideline on how to contribute?
@jowilf
Copy link
Owner

jowilf commented Oct 22, 2023 •
edited
Loading

Thank you for your interest. I will definitely work on a Contribution guide. In the meantime, you can follow this guide on my other repository, which is also applicable to this repository -> https://github.com/jowilf/starlette-admin/blob/main/CONTRIBUTING.md#your-first-code-contribution

@regisin
Copy link
Author

regisin commented Oct 23, 2023

Alright, I tried my best, I submitted a PR. I apologize, I never "squashed" commits before.

@hasansezertasan hasansezertasan mentioned this issue Jan 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@regisin @jowilf