Server Cleanup: Remove GRPC and GRPC Gateway #173
Comments
This was referenced Aug 19, 2024
|
We need to wait for stateful/vscode-runme#1559 to be merged and released. Once that happens we can
Foyle changes are released in https://github.com/jlewi/foyle/releases/tag/v0.0.16 |
jlewi
added a commit
that referenced
this issue
Aug 20, 2024
…ct protocol (#198) * We want the frontend to use the connect protocol and connect SDKs to send RPCs to the backend. * Currently its using gRPC and the service is defined in the vscode protos https://github.com/stateful/runme/blob/main/pkg/api/proto/runme/ai/v1alpha1/ai.proto * This PR adds a new RPC defined in the Foyle protos that the front end can use to send completion RPCs. * The handler implements the connect protocol so the client will be able to use the connect protocol to connect to the server. * Related to #173
|
RunMe Changes to use the connect protocol were merged in Should be in the next release which will be 3.7.3 |
|
3.7.3 has been released So we should be able to proceed with removing gRPC and gRPC gateway. |
jlewi
added a commit
that referenced
this issue
Sep 2, 2024
* Since we are using the connect protocol and server we can remove gRPC and gRPC-gateway support * This means we no longer need to have a server listening for gRPC * We also don't need to rely on the gRPC gateway to make the Agent service accessible fromt the VSCodeExtension because that is now using the connect protocol. * We can also get rid of the RunMe proxy because the vscode extension is now using the clients generated from the foyle buf schema registry in buf. Related to #173
jlewi
added a commit
that referenced
this issue
Sep 2, 2024
* Since we are using the connect protocol and server we can remove gRPC and gRPC-gateway support * This means we no longer need to have a server listening for gRPC * We also don't need to rely on the gRPC gateway to make the Agent service accessible fromt the VSCodeExtension because that is now using the connect protocol. * We can also get rid of the RunMe proxy because the vscode extension is now using the clients generated from the foyle buf schema registry in buf. Related to #173
jlewi
added a commit
to stateful/runme
that referenced
this issue
Sep 2, 2024
* Foyle is now publishing its protos to the buf registry and the client libraries pulled from the registry are what's used by the vscode extension. * The AI service defined in the runme repository is no longer needed. * Related to jlewi/foyle#173
|
#225 removed the code. |
jlewi
added a commit
to jlewi/docs.runme.dev
that referenced
this issue
Sep 2, 2024
* RunMe vscode extension no longer uses gRPC to talk to the AI service * It uses the connect protocol and the option Ai Base URL to set the address * Update the docs to reflect the change. * Related to jlewi/foyle#173
sourishkrout
pushed a commit
to stateful/docs.runme.dev
that referenced
this issue
Sep 14, 2024
* RunMe vscode extension no longer uses gRPC to talk to the AI service * It uses the connect protocol and the option Ai Base URL to set the address * Update the docs to reflect the change. * Related to jlewi/foyle#173
sourishkrout
added a commit
to stateful/docs.runme.dev
that referenced
this issue
Sep 14, 2024
* RunMe vscode extension no longer uses gRPC to talk to the AI service * It uses the connect protocol and the option Ai Base URL to set the address * Update the docs to reflect the change. * Related to jlewi/foyle#173 Co-authored-by: Jeremy Lewi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should just use the connect server. This will simplify things a lot.
We'll need to migrate the vscode extension to connect to the connect server rather than the gRPC server. Since our connect server is running on the prefix "/api"; gRPC won't work. However, since we plan on using the connect protocol for GhostCells it makes sense to use the connect protocol throughout the vscode extension when connecting to Foyle.
The text was updated successfully, but these errors were encountered: