Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skill simulator #26

Open
ysaaron opened this issue Sep 22, 2019 · 1 comment
Open

Skill simulator #26

ysaaron opened this issue Sep 22, 2019 · 1 comment

Comments

@ysaaron
Copy link

ysaaron commented Sep 22, 2019

Do you want to request a feature or report a bug?

feature

What is the expected behavior?

Add skill simulator

Hi @jigsawye ,

A proposal to add skill simulator, and it may be useful for other features in the future to build like damage calculation etc..., how do you think about it?

As below is a simple prototype in the fork repo, if you're interested about it, please have a look
screencapture-localhost-3000-2019-09-22-22_50_22
screencapture-localhost-3000-2019-09-22-22_09_58
screencapture-localhost-3000-2019-09-22-22_48_03
screencapture-localhost-3000-2019-09-22-22_46_27

git compare

@jigsawye
Copy link
Owner

Hi @ysaaron,
Thank you for the proposal. It looks nice. Looking forward to seeing you finish the prototype.
Please note that:

  • I didn’t add tests to this project. You have to test all the existed features manually.
  • You need to make sure that the save/load features are not broken. All the saved
    data should be fallback to the default skill data.

You can create a pull request and we will have a further discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants