Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to disable the "View pipeline with" links on each job #1016

Open
sparrowt opened this issue Jan 10, 2025 · 0 comments
Open

Ability to disable the "View pipeline with" links on each job #1016

sparrowt opened this issue Jan 10, 2025 · 0 comments

Comments

@sparrowt
Copy link

sparrowt commented Jan 10, 2025

What feature do you want to see added?

Firstly this plugin is awesome, thank you!

It would be nice to have an option to disable the link from every job / run page which looks like this:

Image

To aide searchability, the text in the above picture is:

OpenTelemetry
View pipeline with [display name]

(the display name being configurable at /manage/configure > OpenTelemetry Visualisation > Elastic Observability > Advanved > Display Name)

If you remove the 'Elastic Observability' entirely from the 'Visualisation' config then instead every job shows a big link like this:

Please define an OpenTelemetry Visualisation URL of pipelines in Jenkins configuration

I would like to have OpenTelemetry installed and emitting data to Elastic, but (to start with at least) not promote this fact to all the developers who use this Jenkins instance. Some different reasons why we/others may also want to do this:

  • a desire to not advertise the (amazing!) functionality until we have proved that it can cope with the load & ironed out any issues, in order to avoid disappointing people in case we have to disable some/all of it
  • or some people may simply want to collect only metrics by leaving otel.metrics.exporter=otlp but setting otel.traces.exporter=none at which point the links through to APM are unhelpful because there won't be any transaction+span data there at all.

So in a sense there are 2 parts to this, one of which is arguably a bug but I've kept it in this single 'Enhancement' ticket to start with:

  1. Feature request: general ability to disable the links even if traces are being exported
  2. Bug: links should be automatically hidden if traces are not being exported, because in that case the links are not relevant

Upstream changes

No response

Are you interested in contributing this feature?

I'm unlikely to have time to do this soon but AFAICS this is the relevant code.

Perhaps a plugin boolean config to disable the links entirely (item 1. above) which could also be used as a workaround for the bug (item 2.) would be quite simple but I'm new to this code base so it would take some figuring out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant