Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for KMS and keystore signers in Relay #100

Open
onbjerg opened this issue Nov 26, 2024 · 4 comments
Open

Add support for KMS and keystore signers in Relay #100

onbjerg opened this issue Nov 26, 2024 · 4 comments
Assignees
Labels
A-wallet C-enhancement New feature or request

Comments

@onbjerg
Copy link
Member

onbjerg commented Nov 26, 2024

Extend the current signer flags to accept different kinds of signers, like AWS KMS and keystore signers.

Note that these flags should be mutually exclusive, e.g. if I pass --secret-key, I cannot also enable AWS KMS.

Depends on #90

@onbjerg onbjerg added A-wallet C-enhancement New feature or request labels Nov 26, 2024
@aroralanuk
Copy link

If this is open to external contributors, can I pick this up?

@onbjerg
Copy link
Member Author

onbjerg commented Dec 16, 2024

Sure! Some inspiration here: https://github.com/init4tech/builder/blob/375d976c112f0a7e6de0d4c9790166805bcc1e92/src/signer.rs#L52

@aroralanuk
Copy link

Sorry for the delay. I'm running into an issue testing the simple 7702 example here: https://github.com/ithacaxyz/odyssey-examples/tree/main/chapter1/simple-7702 on the like kurtosis network instead of anvil. It gets stuck at forge create SimpleDelegateContract --private-key $BOB_PK --broadcast even with 100x gas price.

This is the WIP PR I'm working on: aroralanuk#1.

(Also, I cannot find a tg group or support channel for odyssey if there's any)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-wallet C-enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants