[PB-3237] feat/add folder creation queue #1419
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| folderQueue.drain(checkCompletion); | ||
| filesQueue.drain(checkCompletion); | ||
|
|
||
| levels.forEach(async (level) => { |
There was a problem hiding this comment.
why async without await? forEach is sequential, so unless you are planning to do a Promise.all or something like that, this is not needed
There was a problem hiding this comment.
You are right, I have already removed it.
Regarding the stats I have put a comment in jira
https://inxt.atlassian.net/browse/PB-3236?focusedCommentId=32663
Deploying drive-web with
|
| Latest commit: |
9a6c360
|
| Status: | ⚡️ Build in progress... |
| @@ -959,9 +959,7 @@ const uploadItems = async (props: DriveExplorerProps, rootList: IRoot[], files: | |||
| onSuccess: onDragAndDropEnd, | |||
| }, | |||
| })); | |||
| dispatch(storageThunks.uploadMultipleFolderThunkNoCheck(folderDataToUpload)).then(() => { | |||
| dispatch(fetchSortedFolderContentThunk(currentFolderId)); | |||
There was a problem hiding this comment.
Is this no longer necessary for the folder to be displayed in order?
There was a problem hiding this comment.
Yes it is needed but I had to move it inside uploadMultipleFolderThunkNoCheck
| .unwrap() | ||
| .then(() => { | ||
| alreadyUploaded += level.files.length; | ||
| alreadyUploaded += 1; |
There was a problem hiding this comment.
Here I have not made any changes, it is used to calculate the progress of uploaded files.
There was a problem hiding this comment.
Even if the code didn't change in that part, we can take advantage of the task and refactor this line with alreadyUploaded += level.files.length + 1; to keep the code cleaner
| } | ||
| }; | ||
|
|
||
| const checkCompletion = async () => { |
There was a problem hiding this comment.
does this function need to be async?
There was a problem hiding this comment.
Not now, I remove it, thanks!
|
Description
Added a folder creation queue that creates folders in parallel to the files, so file uploads are not stuck waiting for folder creations
Related Issues
Related Pull Requests
Checklist
How Has This Been Tested?
Additional Notes