Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove amenity and tourism not null from osm buildings extraction #327

Open
manjitapandey opened this issue Dec 31, 2024 · 2 comments
Open

Comments

@manjitapandey
Copy link

While extracting building features from osm, currently we use three parameters buildings not null, tourism not null and amenity not null.

I purpose to remove tourism and amenity and only add buildings not null while extracting features from osm.

Reason to remove: In FMTM when extracting the data extracts, In cases of amenity like schools and hospitals there are two polygons; one of actual building with building not null tag and another area of school or hospital where amenity is not null but building tag is null. Visualising both amenity and buildings in FMTM makes it difficult to select individual building sometimes. In such cases, its better to remove amenity and only use building not null tags.
Similar is the case for tourism, the parks and gardens also have tourism not null but buildings so using tourism not null provides inaccurate extracts. For the cases like hotels, both tourism and buildings are not null hence they will be included.

Image

@spwoodcock
Copy link
Member

Thanks for looking into it 😃

This was a decision originally by @robsavoye I think & I imagine there is probably a reason we use all three tags - he knows quite a lot about OSM data internals!

Sorry to ping you Rob, but are you able to shed any light on this? 🙏

@rsavoye
Copy link
Collaborator

rsavoye commented Jan 14, 2025

That config file was originally created for my style of building mapping when out field mapping, and pre-dates FMTM by several years. :-) Many buildings are amenities, for example things like public toilets, which I map a lot of, which often have no building tag at all. Most of my building mapping these days is very small rural hamlets where most of the buildings, if any, aren't in OSM (yet). I'm not using data extracts for buildings most of the time as there aren't any to extract. As I don't use the version in osm-fieldwork anymore, feel free to change whatever you need to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants