Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: missing preview links requirements to a PR #53

Open
angelicawill opened this issue Jan 15, 2025 · 2 comments
Open

Problem: missing preview links requirements to a PR #53

angelicawill opened this issue Jan 15, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@angelicawill
Copy link
Contributor

Before, I remember it was a rule that PRs should include a link to the prototype preview before requesting a review. However, I can't find this requirement explicitly documented in the contribution guidelines.
@angelicawill
Copy link
Contributor Author

angelicawill commented Jan 15, 2025 •
edited
Loading

@zolotokrylin @markholdex can you clarify if this is still a requirement? or else you can close this issue as unplanned, thanks!

@zolotokrylin
Copy link
Member

Yes, it should be a requirement. Thanks for spotting it!

@markholdex markholdex added the bug Something isn't working label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zolotokrylin @markholdex @angelicawill