Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable tests that are skipped in CI #923

Closed
ml-evs opened this issue Feb 7, 2024 · 3 comments · Fixed by #925
Closed

Re-enable tests that are skipped in CI #923

ml-evs opened this issue Feb 7, 2024 · 3 comments · Fixed by #925

Comments

@ml-evs
Copy link
Collaborator

ml-evs commented Feb 7, 2024

#922 disables some tests as they do not work with the latest numpy/pandas combo. This may be because the test code itself is broken, or bad numpy/pandas calls are being made in the featurizer or an upstream dep.
@JaGeo
Copy link
Contributor

JaGeo commented Feb 8, 2024

@ml-evs Should one also dis-enable the corresponding featurizers as well for now?
See #915 (comment)

@ml-evs
Copy link
Collaborator Author

ml-evs commented Feb 8, 2024

@ml-evs Should one also dis-enable the corresponding featurizers as well for now?
See #915 (comment)

Yeah I think that's next on the list, I just want to verify that it's not the test cases themselves that are the problem first

@ml-evs ml-evs mentioned this issue Mar 26, 2024
Merged
@ml-evs
Copy link
Collaborator Author

ml-evs commented Mar 26, 2024

Closed by #925

@ml-evs ml-evs closed this as completed Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reintroduce pandas pin and update code for numpy 1.24+ hackingmaterials/matminer
2 participants
@ml-evs @JaGeo