Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't guess these anime episode numbers #667

Open
jpf4e opened this issue Jan 26, 2021 · 6 comments · May be fixed by #778
Open

Can't guess these anime episode numbers #667

jpf4e opened this issue Jan 26, 2021 · 6 comments · May be fixed by #778
Labels
Invalid Guess Result

Comments

@jpf4e
Copy link

jpf4e commented Jan 26, 2021 •
edited
Loading

I am using the latest develop version of Bazarr and it uses GuessIt v3.0.1 I believe.
It is having a hard time figuring out the episodes in the anime releases below.

Related issues:
morpheus65535/bazarr#1234
morpheus65535/bazarr#1245

(This first guess was tried using v3.1.1 and v3.2.0.)

For: That Time I Got Reincarnated as a Slime/Season 2/[EMBER] Tensei Shitara Slime Datta Ken S2 - 01.mkv
GuessIt found: {
    "season": 2,
    "release_group": "EMBER",
    "title": "Tensei Shitara Slime Datta Ken",
    "episode_title": "01",
    "container": "mkv",
    "mimetype": "video/x-matroska",
    "type": "episode"
}

For: Attack on Titan/Season 3/[HorribleSubs] Shingeki no Kyojin S3 - 59 [1080p].mkv
GuessIt found: {
    "season": 3,
    "release_group": "HorribleSubs",
    "title": "Shingeki no Kyojin",
    "episode_title": "59",
    "screen_size": "1080p",
    "container": "mkv",
    "mimetype": "video/x-matroska",
    "type": "episode"
}

Could this already be fixed in a newer version, or does GuessIt have trouble parsing anime?
@Toilal
Copy link
Member

Toilal commented Feb 3, 2021

This rule is not implemented, but it should be possible to promote episode_title to episode when it's a number.

@morpheus65535
Copy link

Yes, if type is episode and if there isn't an episode attribute, the latter should be the same as episode_title but only if it can be casted as an int.

@jpf4e
Copy link
Author

jpf4e commented Feb 3, 2021 •
edited
Loading

Please note that in the first example it doesn't detect the episode numbering (01) as the episode_title so it might not be enough to always map it to the episode field.

@Toilal
Copy link
Member

Toilal commented Feb 4, 2021

Please note that in the first example it doesn't detect the episode numbering (01) as the episode_title so it might not be enough to always map it to the episode field.

What do you mean ?

For: That Time I Got Reincarnated as a Slime/Season 2/[EMBER] Tensei Shitara Slime Datta Ken S2 - 01.mkv
GuessIt found: {
    "season": 2,
    "release_group": "EMBER",
    "title": "Tensei Shitara Slime Datta Ken",
    "episode_title": "01",
    "container": "mkv",
    "mimetype": "video/x-matroska",
    "type": "episode"
}

@morpheus65535
Copy link

When using Guessit 3.0.1, the episode_title isn't in match result. Fortunately, with 3.1.1 (used in latest version of Bazarr) and 3.2.0, it's there.

@jpf4e
Copy link
Author

jpf4e commented Feb 4, 2021

Oh right. I had in mind the result was always the same despite the version.
I'm going to update the description.

@zoriya zoriya linked a pull request May 30, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Invalid Guess Result
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add episode title promotion rule zoriya/guessit
3 participants
@Toilal @morpheus65535 @jpf4e