Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse addNextButton() for Capture location and drop pin tasks #2997

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

shobhitagarwal1612
Copy link
Member

This PR is a pure refactor which is split from #2986 so that main logic change can be separated from refactors.

Things done:

  • Adds support for hiding the next button in the base helper method
  • Reuse the same function in drop pin and capture location tasks.

@anandwana001 PTAL?

@auto-assign auto-assign bot requested a review from scolsen January 10, 2025 12:33
@shobhitagarwal1612 shobhitagarwal1612 requested review from anandwana001 and removed request for scolsen January 10, 2025 12:33
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.42%. Comparing base (4a5d796) to head (d3ee680).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2997      +/-   ##
============================================
- Coverage     63.49%   63.42%   -0.07%     
  Complexity     1241     1241              
============================================
  Files           267      267              
  Lines          6509     6497      -12     
  Branches        911      911              
============================================
- Hits           4133     4121      -12     
  Misses         1790     1790              
  Partials        586      586              
Files with missing lines Coverage Δ
...tion/tasks/location/CaptureLocationTaskFragment.kt 54.34% <100.00%> (-5.27%) ⬇️
.../datacollection/tasks/point/DropPinTaskFragment.kt 76.92% <100.00%> (-3.08%) ⬇️

@shobhitagarwal1612 shobhitagarwal1612 merged commit f4ae82f into master Jan 13, 2025
5 checks passed
@shobhitagarwal1612 shobhitagarwal1612 deleted the ashobhit/2993/add-next-cleanup branch January 13, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants