Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Toast when offline in Download #2990

Merged

Conversation

anandwana001
Copy link
Collaborator

@anandwana001 anandwana001 commented Jan 8, 2025

Towards #662

This is a part 1 PR where we are showing a popup if device is not connected while trying to download the offline imagery.

  • When offline, show message "You are offline. Connect to download offline map imagery".

Part 2 will be

  • If download fails, show error ("Connection lost") or similar.
    The part 2 will close other tickets as well where we need to build download cancel feature,

@shobhitagarwal1612 PTAL?

@auto-assign auto-assign bot requested a review from sufyanAbbasi January 8, 2025 11:30
@anandwana001 anandwana001 force-pushed the anandwana001/662/connectivity-check-download branch from 0867b76 to 4390a14 Compare January 8, 2025 11:36
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Project coverage is 63.38%. Comparing base (243d7cd) to head (69b079a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...flineareas/selector/OfflineAreaSelectorFragment.kt 20.00% 3 Missing and 1 partial ⚠️
...lineareas/selector/OfflineAreaSelectorViewModel.kt 50.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2990      +/-   ##
============================================
- Coverage     63.42%   63.38%   -0.05%     
- Complexity     1241     1242       +1     
============================================
  Files           267      267              
  Lines          6497     6508      +11     
  Branches        911      913       +2     
============================================
+ Hits           4121     4125       +4     
- Misses         1790     1796       +6     
- Partials        586      587       +1     
Files with missing lines Coverage Δ
...lineareas/selector/OfflineAreaSelectorViewModel.kt 29.48% <50.00%> (+1.70%) ⬆️
...flineareas/selector/OfflineAreaSelectorFragment.kt 38.98% <20.00%> (-1.76%) ⬇️

Copy link
Member

@shobhitagarwal1612 shobhitagarwal1612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning to add some unit tests for this?

@anandwana001
Copy link
Collaborator Author

Are you planning to add some unit tests for this?

in second pr, for complete testing.

…eck-download' into anandwana001/662/connectivity-check-download
@shobhitagarwal1612 shobhitagarwal1612 merged commit cb34a56 into master Jan 13, 2025
5 checks passed
@shobhitagarwal1612 shobhitagarwal1612 deleted the anandwana001/662/connectivity-check-download branch January 13, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants