-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Toast when offline in Download #2990
Show Toast when offline in Download #2990
Conversation
0867b76
to
4390a14
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2990 +/- ##
============================================
- Coverage 63.42% 63.38% -0.05%
- Complexity 1241 1242 +1
============================================
Files 267 267
Lines 6497 6508 +11
Branches 911 913 +2
============================================
+ Hits 4121 4125 +4
- Misses 1790 1796 +6
- Partials 586 587 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you planning to add some unit tests for this?
in second pr, for complete testing. |
...main/java/com/google/android/ground/ui/offlineareas/selector/OfflineAreaSelectorViewModel.kt
Outdated
Show resolved
Hide resolved
...main/java/com/google/android/ground/ui/offlineareas/selector/OfflineAreaSelectorViewModel.kt
Outdated
Show resolved
Hide resolved
.../main/java/com/google/android/ground/ui/offlineareas/selector/OfflineAreaSelectorFragment.kt
Outdated
Show resolved
Hide resolved
…eck-download' into anandwana001/662/connectivity-check-download
Towards #662
This is a part 1 PR where we are showing a popup if device is not connected while trying to download the offline imagery.
Part 2 will be
The part 2 will close other tickets as well where we need to build download cancel feature,
@shobhitagarwal1612 PTAL?