Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compose] Migrate number task to compose UI #2977

Merged
merged 4 commits into from
Jan 3, 2025

Conversation

shobhitagarwal1612
Copy link
Member

@shobhitagarwal1612 shobhitagarwal1612 commented Jan 2, 2025

Towards #1975

Replace number task with compose based UI.

compose number task

@anandwana001 @gino-m PTAL?

@auto-assign auto-assign bot requested a review from sufyanAbbasi January 2, 2025 16:23
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Project coverage is 62.10%. Comparing base (e411546) to head (9905097).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../datacollection/tasks/number/NumberTaskFragment.kt 70.00% 0 Missing and 3 partials ⚠️
...ound/ui/datacollection/components/TextTaskInput.kt 66.66% 0 Missing and 1 partial ⚠️
...d/ui/datacollection/tasks/text/TextTaskFragment.kt 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2977      +/-   ##
============================================
- Coverage     62.14%   62.10%   -0.05%     
- Complexity     1204     1206       +2     
============================================
  Files           266      266              
  Lines          6433     6434       +1     
  Branches        901      905       +4     
============================================
- Hits           3998     3996       -2     
  Misses         1871     1871              
- Partials        564      567       +3     
Files with missing lines Coverage Δ
...google/android/ground/ui/common/BindingAdapters.kt 81.25% <ø> (-2.09%) ⬇️
...datacollection/tasks/number/NumberTaskViewModel.kt 100.00% <100.00%> (ø)
...ound/ui/datacollection/components/TextTaskInput.kt 58.82% <66.66%> (ø)
...d/ui/datacollection/tasks/text/TextTaskFragment.kt 55.55% <66.66%> (+12.69%) ⬆️
.../datacollection/tasks/number/NumberTaskFragment.kt 69.23% <70.00%> (-30.77%) ⬇️

... and 1 file with indirect coverage changes

@shobhitagarwal1612 shobhitagarwal1612 merged commit acb6193 into master Jan 3, 2025
5 checks passed
@shobhitagarwal1612 shobhitagarwal1612 deleted the ashobhit/composify/number branch January 3, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants