Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OCT-1822] apitest: potential fix for nonce-too-low problem #603

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

paulperegud
Copy link
Contributor

Fixes OCT-1822. Potentially helps with apitest flakiness.

Description

Definition of Done

  1. If required, the desciption of your change is added to the QA changelog
  2. Acceptance criteria are met.
  3. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  4. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  5. Unit tests are added unless there is a reason to omit them.
  6. Automated tests are added when required.
  7. The code is merged.
  8. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  9. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

Fixes OCT-1822. Potentially helps with apitest flakiness.
Copy link

linear bot commented Dec 23, 2024

backend/tests/conftest.py Show resolved Hide resolved
kgarbacinski
kgarbacinski previously approved these changes Dec 24, 2024
Copy link
Contributor

@kgarbacinski kgarbacinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulperegud paulperegud added the request-approval Request approval from the Housekeeper label Jan 13, 2025
@aziolek
Copy link
Member

aziolek commented Jan 13, 2025

I cancelled E2E workflow. This branch is not up to date with develop where we have many more tests & also adjustment for BE stability during CI runs. I will merge develop and rerun the tests.

@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 13, 2025
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12746110428 failed 💥

@aziolek aziolek added the request-approval Request approval from the Housekeeper label Jan 13, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 13, 2025
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12746602765 failed 💥

Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12746602765 failed 💥

@aziolek aziolek added the request-approval Request approval from the Housekeeper label Jan 14, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 14, 2025
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12765240893 failed 💥

Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12765240893 passed 🎉

@aziolek aziolek changed the base branch from develop to master January 14, 2025 20:49
@aziolek aziolek dismissed stale reviews from housekeeper-bot, kgarbacinski, and MateuszStoleckiGLM January 14, 2025 20:49

The base branch was changed.

@aziolek aziolek changed the base branch from master to develop January 14, 2025 20:49
@aziolek aziolek merged commit 7486963 into develop Jan 14, 2025
47 checks passed
@aziolek aziolek deleted the apitest/fix-erc20.py-flakiness branch January 14, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants