Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCT-2130: Home Donations E2E + OCT:2133: Home Transactions E2E #592

Merged
merged 16 commits into from
Dec 19, 2024
Merged

OCT-2130: Home Donations E2E + OCT:2133: Home Transactions E2E #592

merged 16 commits into from
Dec 19, 2024

Conversation

jmikolajczyk
Copy link
Contributor

@jmikolajczyk jmikolajczyk commented Dec 17, 2024 •
edited
Loading

Description

Definition of Done

  1. If required, the desciption of your change is added to the QA changelog
  2. Acceptance criteria are met.
  3. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  4. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  5. Unit tests are added unless there is a reason to omit them.
  6. Automated tests are added when required.
  7. The code is merged.
  8. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  9. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@linear Linear
Copy link

linear bot commented Dec 17, 2024

OCT-2130 Home Donations E2E

@jmikolajczyk jmikolajczyk self-assigned this Dec 17, 2024
@jmikolajczyk jmikolajczyk changed the title Test/oct 2130 home donations e2e OCT-2130: Home Donations E2E + OCT-2131: Home Personal Allocation E2E + OCT:2133: Home Transactions E2E Dec 17, 2024
@linear Linear
Copy link

linear bot commented Dec 17, 2024

OCT-2131 Home Personal Allocation E2E

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Dec 17, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 17, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12364311677 failed 💥

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Dec 17, 2024
@jmikolajczyk jmikolajczyk added request-approval Request approval from the Housekeeper and removed request-approval Request approval from the Housekeeper labels Dec 17, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 17, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12372707299 failed 💥

housekeeper-bot
housekeeper-bot requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12373427296 failed 💥

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Dec 17, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 17, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12374974252 failed 💥

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Dec 17, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 17, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12381438901 failed 💥

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Dec 17, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 17, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12382500082 failed 💥

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Dec 18, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 18, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12394033871 failed 💥

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Dec 18, 2024
@jmikolajczyk
Copy link
Contributor Author

/deploy

@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 18, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12395361956 failed 💥

@jmikolajczyk jmikolajczyk changed the title OCT-2130: Home Donations E2E + OCT-2131: Home Personal Allocation E2E + OCT:2133: Home Transactions E2E OCT-2130: Home Donations E2E + OCT:2133: Home Transactions E2E Dec 18, 2024
@jmikolajczyk jmikolajczyk requested a review from aziolek December 18, 2024 17:35
@jmikolajczyk jmikolajczyk marked this pull request as ready for review December 18, 2024 17:35
@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Dec 18, 2024
@jmikolajczyk jmikolajczyk mentioned this pull request Dec 18, 2024
Merged
14 tasks
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 18, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12398752701 failed 💥

housekeeper-bot
housekeeper-bot previously approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12398752701 passed 🎉

@jmikolajczyk jmikolajczyk added request-approval Request approval from the Housekeeper and removed request-approval Request approval from the Housekeeper labels Dec 19, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12410375428 failed 💥

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Dec 19, 2024
@aziolek aziolek merged commit 7b79db7 into master Dec 19, 2024
13 of 14 checks passed
@aziolek aziolek deleted the test/oct-2130-home-donations-e2e branch December 19, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aziolek aziolek aziolek left review comments

@housekeeper-bot housekeeper-bot housekeeper-bot requested changes

Assignees

@jmikolajczyk jmikolajczyk

Labels
request-approval Request approval from the Housekeeper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmikolajczyk @aziolek @housekeeper-bot