Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCT-2219: Allocations/ endpoints migration to FastAPI #569

Merged
merged 14 commits into from
Dec 3, 2024

Conversation

adam-gf
Copy link
Contributor

@adam-gf adam-gf commented Nov 28, 2024

Description

   + GET /allocations/epoch/{epoch}
   + GET /allocations/users/{address}/allocation_nonce
   + POST /allocations/allocate
   + GET /allocations/donors/{epoch}
   + GET /allocations/project/{proposal_address}/epoch/{epoch}
   + GET /allocations/user/{user_address}/epoch/{epoch}
   - POST /allocations/leverage/{user_address}

Definition of Done

  1. If required, the desciption of your change is added to the QA changelog
  2. Acceptance criteria are met.
  3. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  4. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  5. Unit tests are added unless there is a reason to omit them.
  6. Automated tests are added when required.
  7. The code is merged.
  8. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  9. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

Copy link

linear bot commented Nov 28, 2024

OCT-2219 Logic

@adam-gf adam-gf self-assigned this Nov 28, 2024
@adam-gf adam-gf requested a review from kgarbacinski November 28, 2024 08:43
Copy link
Contributor

@kgarbacinski kgarbacinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double-check also the commit message, I'm not sure if we're referencing to the correct task number.

backend/tests/modules/v2/test_allocations_v2.py Outdated Show resolved Hide resolved
backend/tests/modules/v2/test_allocations_v2.py Outdated Show resolved Hide resolved
backend/tests/modules/v2/conftest.py Outdated Show resolved Hide resolved
backend/tests/modules/v2/conftest.py Outdated Show resolved Hide resolved
backend/tests/modules/v2/conftest.py Outdated Show resolved Hide resolved
backend/tests/modules/v2/test_allocations_v2.py Outdated Show resolved Hide resolved
backend/tests/modules/v2/test_allocations_v2.py Outdated Show resolved Hide resolved
backend/tests/modules/v2/utils.py Outdated Show resolved Hide resolved
backend/tests/modules/v2/test_allocations_v2.py Outdated Show resolved Hide resolved
backend/tests/modules/v2/test_allocations_v2.py Outdated Show resolved Hide resolved
kgarbacinski
kgarbacinski previously approved these changes Dec 2, 2024
Copy link
Contributor

@kgarbacinski kgarbacinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's keep in minds to address some of the unresolved comments yet in the next tasks

@adam-gf adam-gf added the request-approval Request approval from the Housekeeper label Dec 2, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 2, 2024
housekeeper-bot
housekeeper-bot previously approved these changes Dec 2, 2024
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12118684429 passed 🎉

@housekeeper-bot housekeeper-bot temporarily deployed to master December 2, 2024 12:05 Destroyed
@housekeeper-bot housekeeper-bot dismissed stale reviews from kgarbacinski and themself via 9cc2d39 December 2, 2024 12:13
kgarbacinski
kgarbacinski previously approved these changes Dec 2, 2024
@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Dec 2, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 2, 2024
housekeeper-bot
housekeeper-bot previously approved these changes Dec 2, 2024
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12119660406 passed 🎉

@adam-gf adam-gf dismissed stale reviews from housekeeper-bot and kgarbacinski via 3d9beda December 2, 2024 13:28
@housekeeper-bot housekeeper-bot temporarily deployed to master December 2, 2024 13:40 Destroyed
@housekeeper-bot housekeeper-bot temporarily deployed to master December 2, 2024 15:31 Destroyed
@adam-gf adam-gf added the request-approval Request approval from the Housekeeper label Dec 3, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 3, 2024
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12135341502 passed 🎉

Copy link
Contributor

@kgarbacinski kgarbacinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adam-gf adam-gf merged commit dbdc2be into develop Dec 3, 2024
60 checks passed
@adam-gf adam-gf deleted the fast-migration-allocations branch December 3, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants