Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCT-2144: Calendar E2E #564

Merged
merged 23 commits into from
Nov 29, 2024
Merged

OCT-2144: Calendar E2E #564

merged 23 commits into from
Nov 29, 2024

Conversation

jmikolajczyk
Copy link
Contributor

Description

Definition of Done

  1. If required, the desciption of your change is added to the QA changelog
  2. Acceptance criteria are met.
  3. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  4. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  5. Unit tests are added unless there is a reason to omit them.
  6. Automated tests are added when required.
  7. The code is merged.
  8. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  9. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@jmikolajczyk jmikolajczyk self-assigned this Nov 22, 2024
Copy link

linear bot commented Nov 22, 2024

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Nov 22, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Nov 22, 2024
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #11975074013 failed 💥

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Nov 25, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Nov 25, 2024
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12009289797 failed 💥

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Nov 25, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Nov 25, 2024
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12013815614 failed 💥

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Nov 25, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Nov 25, 2024
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12015307305 failed 💥

@jmikolajczyk
Copy link
Contributor Author

/deploy

@jmikolajczyk
Copy link
Contributor Author

/deploy

@jmikolajczyk
Copy link
Contributor Author

/destroy

@jmikolajczyk
Copy link
Contributor Author

/deploy

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Nov 26, 2024
@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Nov 26, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Nov 26, 2024
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12040060568 passed 🎉

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Nov 26, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Nov 26, 2024
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12040269716 passed 🎉

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Nov 26, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Nov 27, 2024
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12040581774 failed 💥

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Nov 27, 2024
@jmikolajczyk jmikolajczyk marked this pull request as ready for review November 27, 2024 10:00
@jmikolajczyk jmikolajczyk requested a review from aziolek November 27, 2024 10:00
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Nov 27, 2024
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12046787316 passed 🎉

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Nov 27, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Nov 27, 2024
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12049300552 passed 🎉

@jmikolajczyk jmikolajczyk mentioned this pull request Nov 27, 2024
14 tasks
@jmikolajczyk jmikolajczyk changed the title oct-2144: calendar e2e OCT-2144: Calendar E2E Nov 28, 2024
@jmikolajczyk jmikolajczyk merged commit 1938ebe into master Nov 29, 2024
47 checks passed
@jmikolajczyk jmikolajczyk deleted the test/oct-2144-calendar-e2e branch November 29, 2024 11:05
jmikolajczyk added a commit that referenced this pull request Dec 2, 2024
## Description
Check after [PR-564](#564)
## Definition of Done

1. [ ] If required, the desciption of your change is added to the [QA
changelog](https://www.notion.so/octantapp/Changelog-for-the-QA-d96fa3b411cf488bb1d8d9a598d88281)
2. [ ] Acceptance criteria are met.
3. [ ] PR is manually tested before the merge by developer(s).
    - [ ] Happy path is manually checked.
4. [ ] PR is manually tested by QA when their assistance is required
(1).
- [ ] Octant Areas & Test Cases are checked for impact and updated if
required (2).
5. [ ] Unit tests are added unless there is a reason to omit them.
6. [ ] Automated tests are added when required.
7. [ ] The code is merged.
8. [ ] Tech documentation is added / updated, reviewed and approved
(including mandatory approval by a code owner, should such exist for
changed files).
    - [ ] BE: Swagger documentation is updated.
9. [ ] When required by QA:
    - [ ] Deployed to the relevant environment.
    - [ ] Passed system tests.

---

(1) Developer(s) in coordination with QA decide whether it's required.
For small tickets introducing small changes QA assistance is most
probably not required.

(2) [Octant Areas & Test
Cases](https://docs.google.com/spreadsheets/d/1cRe6dxuKJV3a4ZskAwWEPvrFkQm6rEfyUCYwLTYw_Cc).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants