Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCT-1809: UQ explanation modal: add new slide #372

Closed
wants to merge 1 commit into from

Conversation

jmikolajczyk
Copy link
Contributor

Description

Definition of Done

  1. Acceptance criteria are met.
  2. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  3. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  4. Unit tests are added unless there is a reason to omit them.
  5. Automated tests are added when required.
  6. The code is merged.
  7. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  8. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Jul 31, 2024
@jmikolajczyk jmikolajczyk requested a review from aziolek July 31, 2024 10:04
@jmikolajczyk jmikolajczyk self-assigned this Jul 31, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jul 31, 2024
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10178188979 failed 💥

Copy link
Member

@aziolek aziolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aziolek
Copy link
Member

aziolek commented Aug 1, 2024

Waits for solution to this thread: => https://linear.app/golemfoundation/issue/OCT-1809/uq-explanation-modal-add-new-slide#comment-c0a6501c

Thread resolved, ticket is cancelled, PR can be closed.

@aziolek aziolek closed this Aug 1, 2024
@aziolek aziolek deleted the feature/oct-1809-onboarding-uq-step branch August 1, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants