Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCT-1833: Websockets don't work (project_donors, project_rewards) #371

Merged
merged 7 commits into from
Aug 8, 2024
Merged

OCT-1833: Websockets don't work (project_donors, project_rewards) #371

merged 7 commits into from
Aug 8, 2024

Conversation

jmikolajczyk
Copy link
Contributor

Description

Definition of Done

  1. Acceptance criteria are met.
  2. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  3. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  4. Unit tests are added unless there is a reason to omit them.
  5. Automated tests are added when required.
  6. The code is merged.
  7. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  8. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Jul 31, 2024
@jmikolajczyk jmikolajczyk requested a review from aziolek July 31, 2024 08:40
@jmikolajczyk jmikolajczyk self-assigned this Jul 31, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jul 31, 2024
housekeeper-bot
housekeeper-bot requested changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10176961050 failed 💥

@aziolek aziolek added the request-approval Request approval from the Housekeeper label Aug 1, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Aug 1, 2024
housekeeper-bot
housekeeper-bot requested changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10196886784 failed 💥

aziolek
aziolek requested changes Aug 1, 2024
View reviewed changes
Copy link
Member

@aziolek aziolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E failed and it's a legit failure: https://github.com/golemfoundation/octant/actions/runs/10196886784/job/28208808235.

@housekeeper-bot housekeeper-bot temporarily deployed to uat August 1, 2024 15:00 Destroyed
@housekeeper-bot housekeeper-bot temporarily deployed to uat August 2, 2024 06:57 Destroyed
@housekeeper-bot housekeeper-bot temporarily deployed to uat August 2, 2024 08:39 Destroyed
@aziolek aziolek added the request-approval Request approval from the Housekeeper label Aug 2, 2024
@housekeeper-bot housekeeper-bot temporarily deployed to uat August 2, 2024 10:46 Destroyed
@aziolek
Copy link
Member

aziolek commented Aug 2, 2024 •
edited
Loading

E2E failed and it's a legit failure: https://github.com/golemfoundation/octant/actions/runs/10196886784/job/28208808235.

Fixed in 947c267.

@housekeeper-bot housekeeper-bot temporarily deployed to uat August 2, 2024 11:00 Destroyed
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Aug 2, 2024
housekeeper-bot
housekeeper-bot requested changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10214311986 failed 💥

@aziolek aziolek added the request-approval Request approval from the Housekeeper label Aug 2, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Aug 2, 2024
housekeeper-bot
housekeeper-bot requested changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10217181648 failed 💥

@housekeeper-bot housekeeper-bot temporarily deployed to uat August 5, 2024 09:04 Destroyed
@housekeeper-bot housekeeper-bot temporarily deployed to uat August 5, 2024 09:19 Destroyed
@aziolek aziolek added the request-approval Request approval from the Housekeeper label Aug 6, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Aug 6, 2024
housekeeper-bot
housekeeper-bot requested changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10263066390 failed 💥

aziolek
aziolek reviewed Aug 6, 2024
View reviewed changes
Copy link
Member

@aziolek aziolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/golemfoundation/octant/actions/runs/10263066390/job/28394323121 looks like legit failure.

image

housekeeper-bot
housekeeper-bot approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10263066390 passed 🎉

@jmikolajczyk jmikolajczyk merged commit 2907f83 into master Aug 8, 2024
47 checks passed
@jmikolajczyk jmikolajczyk deleted the feature/oct-1833-websockets-fix-and-project-donors-update branch August 8, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aziolek aziolek aziolek approved these changes

@housekeeper-bot housekeeper-bot housekeeper-bot approved these changes

@kgarbacinski kgarbacinski Awaiting requested review from kgarbacinski

Assignees

@jmikolajczyk jmikolajczyk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmikolajczyk @aziolek @housekeeper-bot