Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCT-1730: Improvements for the epoch verifier #368

Merged
merged 4 commits into from
Aug 7, 2024
Merged

OCT-1730: Improvements for the epoch verifier #368

merged 4 commits into from
Aug 7, 2024

Conversation

kgarbacinski
Copy link
Contributor

Description

Definition of Done

  1. Acceptance criteria are met.
  2. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  3. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  4. Unit tests are added unless there is a reason to omit them.
  5. Automated tests are added when required.
  6. The code is merged.
  7. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  8. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@kgarbacinski kgarbacinski self-assigned this Jul 30, 2024
@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Jul 30, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jul 30, 2024
housekeeper-bot
housekeeper-bot previously approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10160706492 passed 🎉

aziolek
aziolek reviewed Jul 31, 2024
View reviewed changes
epoch-verifier/src/data/models.ts Outdated Show resolved Hide resolved
epoch-verifier/src/data/models.ts Outdated Show resolved Hide resolved
epoch-verifier/src/verifications/utils.ts Outdated Show resolved Hide resolved
@kgarbacinski kgarbacinski requested a review from aziolek August 1, 2024 07:50
@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Aug 1, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Aug 1, 2024
housekeeper-bot
housekeeper-bot requested changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10197965379 failed 💥

@aziolek
Copy link
Member

aziolek commented Aug 1, 2024

It looks like a crash of the runner (Bilbong), not the E2E itself. I suggest rerun:

image

housekeeper-bot
housekeeper-bot requested changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10197965379 failed 💥

housekeeper-bot
housekeeper-bot requested changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10197965379 failed 💥

housekeeper-bot
housekeeper-bot requested changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10197965379 failed 💥

@aziolek aziolek added the request-approval Request approval from the Housekeeper label Aug 6, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Aug 6, 2024
housekeeper-bot
housekeeper-bot approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10267258414 passed 🎉

@kgarbacinski kgarbacinski added the request-approval Request approval from the Housekeeper label Aug 6, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Aug 6, 2024
housekeeper-bot
housekeeper-bot approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10269899033 passed 🎉

@kgarbacinski kgarbacinski merged commit 43ac141 into develop Aug 7, 2024
54 checks passed
@kgarbacinski kgarbacinski deleted the kacper/feat/oct-1730-epoch-verifier-improvements branch August 7, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@housekeeper-bot housekeeper-bot housekeeper-bot approved these changes

@aziolek aziolek aziolek approved these changes

@paulperegud paulperegud Awaiting requested review from paulperegud

@adam-gf adam-gf Awaiting requested review from adam-gf

Assignees

@kgarbacinski kgarbacinski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kgarbacinski @aziolek @housekeeper-bot