Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX]: multisig TOS #362

Closed
wants to merge 4 commits into from
Closed

[HOTFIX]: multisig TOS #362

wants to merge 4 commits into from

Conversation

jmikolajczyk
Copy link
Contributor

Description

Definition of Done

  1. Acceptance criteria are met.
  2. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  3. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  4. Unit tests are added unless there is a reason to omit them.
  5. Automated tests are added when required.
  6. The code is merged.
  7. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  8. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Jul 26, 2024
@jmikolajczyk jmikolajczyk requested a review from aziolek July 26, 2024 08:49
@jmikolajczyk jmikolajczyk self-assigned this Jul 26, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jul 26, 2024
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10108494353 failed 💥

aziolek
aziolek previously approved these changes Jul 26, 2024
@aziolek aziolek added the request-approval Request approval from the Housekeeper label Jul 26, 2024
@aziolek
Copy link
Member

aziolek commented Jul 26, 2024

Closed in favor of #363.

@aziolek aziolek closed this Jul 26, 2024
@aziolek aziolek deleted the hotfix/multisig-tos branch October 17, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request-approval Request approval from the Housekeeper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants