Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements for apitest and localenv #354

Closed
wants to merge 3 commits into from
Closed

Minor improvements for apitest and localenv #354

wants to merge 3 commits into from

Conversation

paulperegud
Copy link
Contributor

  • don't crash if there are no containers to cleanup when setting up apitest
  • add missing env variables (related to gitcoin passport and delegation)
  • use correct link to anvil image

@paulperegud paulperegud self-assigned this Jul 23, 2024
@paulperegud paulperegud added the request-approval Request approval from the Housekeeper label Jul 23, 2024
@paulperegud paulperegud requested a review from mike-code July 23, 2024 14:56
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jul 23, 2024
housekeeper-bot
housekeeper-bot approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10061161666 passed 🎉

@paulperegud paulperegud force-pushed the localenv-minor-improvements branch from 4886eef to a84e5f9 Compare July 24, 2024 16:06
@paulperegud paulperegud added the request-approval Request approval from the Housekeeper label Jul 24, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jul 24, 2024
housekeeper-bot
housekeeper-bot approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10080151605 passed 🎉

@paulperegud
Copy link
Contributor Author

These commits are already a part of #367, and will be easier to merge there, since better apitest behavior. Closing this PR.

@aziolek aziolek deleted the localenv-minor-improvements branch October 17, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@housekeeper-bot housekeeper-bot housekeeper-bot approved these changes

@mike-code mike-code mike-code approved these changes

Assignees

@paulperegud paulperegud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulperegud @mike-code @housekeeper-bot