Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCT-1803: Adds migration to change uq score for users #349

Conversation

adam-gf
Copy link
Contributor

@adam-gf adam-gf commented Jul 19, 2024

Description

Adds migration to change uq score for users

Definition of Done

  1. Acceptance criteria are met.
  2. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  3. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  4. Unit tests are added unless there is a reason to omit them.
  5. Automated tests are added when required.
  6. The code is merged.
  7. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  8. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@adam-gf adam-gf requested a review from kgarbacinski July 19, 2024 12:34
@adam-gf adam-gf self-assigned this Jul 19, 2024
@adam-gf adam-gf requested a review from housekeeper-bot as a code owner July 19, 2024 12:34
@adam-gf adam-gf requested a review from kgarbacinski July 19, 2024 12:56
@adam-gf adam-gf requested a review from paulperegud July 19, 2024 13:16
Copy link
Member

@aziolek aziolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This waits for #350.

@paulperegud
Copy link
Contributor

@adam-gf please also recheck if addresses should be normalized before comparison with addresses in our DB. AFAIR we store all addresses in normalized with to_checksum_address(...).

kgarbacinski
kgarbacinski previously approved these changes Jul 22, 2024
paulperegud
paulperegud previously approved these changes Jul 22, 2024
@adam-gf adam-gf added the request-approval Request approval from the Housekeeper label Jul 22, 2024
@adam-gf adam-gf dismissed stale reviews from paulperegud and kgarbacinski via c741ad0 July 22, 2024 10:16
@adam-gf adam-gf requested a review from 0xartem July 22, 2024 10:24
@aziolek
Copy link
Member

aziolek commented Jul 22, 2024

#350 is merged.

@aziolek aziolek merged commit 6ade9f3 into develop Jul 22, 2024
31 checks passed
@aziolek aziolek deleted the adam/oct-1803-recalculate-uq-score-of-allocations-done-by-users-eligible branch July 22, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request-approval Request approval from the Housekeeper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants