Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCT-1725: Combine dozens of frontend requests into just a few #346

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

jmikolajczyk
Copy link
Contributor

Description

Definition of Done

  1. Acceptance criteria are met.
  2. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  3. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  4. Unit tests are added unless there is a reason to omit them.
  5. Automated tests are added when required.
  6. The code is merged.
  7. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  8. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@jmikolajczyk jmikolajczyk self-assigned this Jul 19, 2024
@jmikolajczyk jmikolajczyk marked this pull request as ready for review July 22, 2024 11:58
@jmikolajczyk jmikolajczyk requested a review from aziolek July 22, 2024 12:00
@jmikolajczyk jmikolajczyk added the request-approval Request approval from the Housekeeper label Jul 22, 2024
Copy link
Member

@aziolek aziolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now instead of fetching donors per project we need to fetch all the allocations in the epoch and reduce them ourselves? Seems like a step backwards.

@jmikolajczyk
Copy link
Contributor Author

So now instead of fetching donors per project we need to fetch all the allocations in the epoch and reduce them ourselves? Seems like a step backwards.

I don't think so. Instead of making request for each project donors we do only one and reduce data on our side.

@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jul 22, 2024
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #10040357078 passed 🎉

@jmikolajczyk jmikolajczyk merged commit dc2a3b0 into master Jul 29, 2024
31 checks passed
@jmikolajczyk jmikolajczyk deleted the feature/oct-1725-combine-requests branch July 29, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants