Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCT-1786 Update DAO Drops project information in Epoch 4 #343

Closed
wants to merge 21 commits into from

Conversation

0xartem
Copy link
Member

@0xartem 0xartem commented Jul 18, 2024

Description

Definition of Done

  1. Acceptance criteria are met.
  2. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  3. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  4. Unit tests are added unless there is a reason to omit them.
  5. Automated tests are added when required.
  6. The code is merged.
  7. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  8. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@0xartem 0xartem requested a review from housekeeper-bot as a code owner July 18, 2024 09:20
@0xartem 0xartem requested review from aziolek and kgarbacinski July 18, 2024 09:21
@aziolek aziolek changed the title update ipfs cid with new dao drops desc OCT-1786 Update DAO Drops project information in Epoch 4 Jul 18, 2024
aziolek
aziolek previously approved these changes Jul 18, 2024
jmikolajczyk and others added 18 commits July 18, 2024 12:59
## Description

## Definition of Done

1. [ ] Acceptance criteria are met.
2. [ ] PR is manually tested before the merge by developer(s).
    - [ ] Happy path is manually checked.
3. [ ] PR is manually tested by QA when their assistance is required
(1).
- [ ] Octant Areas & Test Cases are checked for impact and updated if
required (2).
4. [ ] Unit tests are added unless there is a reason to omit them.
5. [ ] Automated tests are added when required.
6. [ ] The code is merged.
7. [ ] Tech documentation is added / updated, reviewed and approved
(including mandatory approval by a code owner, should such exist for
changed files).
    - [ ] BE: Swagger documentation is updated.
8. [ ] When required by QA:
    - [ ] Deployed to the relevant environment.
    - [ ] Passed system tests.

---

(1) Developer(s) in coordination with QA decide whether it's required.
For small tickets introducing small changes QA assistance is most
probably not required.

(2) [Octant Areas & Test
Cases](https://docs.google.com/spreadsheets/d/1cRe6dxuKJV3a4ZskAwWEPvrFkQm6rEfyUCYwLTYw_Cc).
## Description
Adds user/uq/<int:epoch>/all for listing uq-user pairs
Copy link
Member

@aziolek aziolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR grew, some missed merge probably.

image

Copy link
Contributor

@kgarbacinski kgarbacinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aziolek aziolek added the request-approval Request approval from the Housekeeper label Jul 18, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jul 18, 2024
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #9991042656 passed 🎉

@aziolek
Copy link
Member

aziolek commented Jul 22, 2024

@0xartem: do we merge that?

@aziolek
Copy link
Member

aziolek commented Jul 24, 2024

Rebasing and repointning to master proved to be too complex to bother. New PR created: https://github.com/golemfoundation/octant/pull/359/files.

@aziolek aziolek closed this Jul 24, 2024
@aziolek aziolek deleted the artem/oct-1786-update-dao-drops branch October 17, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants