Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest version should be mutually exclusive with csproj version #16

Open
philpax opened this issue Aug 19, 2022 · 2 comments
Open

Manifest version should be mutually exclusive with csproj version #16

philpax opened this issue Aug 19, 2022 · 2 comments

Comments

@philpax
Copy link
Contributor

philpax commented Aug 19, 2022

Unclear what the current state of affairs is, but https://discord.com/channels/581875019861328007/929533532185956352/1009523451490484325 suggests that the manifest takes precedence over the csproj.

This shouldn't be the case - we ratified mutual exclusion here goatcorp/DIPs#44 to ensure that we never have two versions that are out of sync.

@wolfcomp
Copy link
Contributor

That is correct due to how manifest version is read and sent to the build and with how dotnet handles the build args it's unable to be written in any other way see BuildProcessor and entrypoint

@philpax
Copy link
Contributor Author

philpax commented Sep 14, 2022

I mean, I don't see why it couldn't accept both versions and error out during the build if both are present, instead of just one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants