feat: move standard library initialization to genesis transactions #3168
Conversation
Signed-off-by: Norman Meier <[email protected]>
.github/workflows/main_template.yml
Outdated
| @@ -33,9 +33,8 @@ jobs: | |||
| uses: ./.github/workflows/test_template.yml | |||
| with: | |||
| modulepath: ${{ inputs.modulepath }} | |||
| tests-timeout: "30m" | |||
| tests-timeout: "60m" | |||
There was a problem hiding this comment.
I think we discussed why this was needed privately, but it's worth nothing here as well 🙏
There was a problem hiding this comment.
I will try to make an optimization in this PR to keep gnoland test around 20min like on master
I keep you posted
| @@ -92,6 +93,9 @@ type Node struct { | |||
| var DefaultFee = std.NewFee(50000, std.MustParseCoin(ugnot.ValueString(1000000))) | |||
|
|
|||
| func NewDevNode(ctx context.Context, cfg *NodeConfig) (*Node, error) { | |||
| stdlibsDeployer := crypto.MustAddressFromString("g1jg8mtutu9khhfwc4nxmuhcpftf0pajdhfvsqf5") // test1, FIXME: replace | |||
There was a problem hiding this comment.
This is fixable I think with @Villaquiranm's PR
There was a problem hiding this comment.
Yeah I think I'll wait on it
EDIT: actually I should probably use the same address as other packages, I will address this before merge
| @@ -116,7 +116,7 @@ func TestStart_Lazy(t *testing.T) { | |||
| io.SetErr(commands.WriteNopCloser(mockErr)) | |||
|
|
|||
| // Create and run the command | |||
| ctx, cancelFn := context.WithTimeout(context.Background(), 10*time.Second) | |||
| ctx, cancelFn := context.WithTimeout(context.Background(), 20*time.Second) | |||
There was a problem hiding this comment.
I organically hate this test :)
There was a problem hiding this comment.
It's a constant reminder of the insane tech debt we have, that's preventing us from easily spinning up configurable clusters in unit tests
There was a problem hiding this comment.
As long as it's organic 🥬 ;)
There was a problem hiding this comment.
I will try to restore the master value on this with opti
gnovm/memfile.go
Outdated
| reFileName = regexp.MustCompile(`^([a-zA-Z0-9_]*\.[a-z0-9_\.]*|LICENSE|README)$`) | ||
| rePkgName = regexp.MustCompile(`^[a-z][a-z0-9_]*$`) | ||
| rePkgOrRlmPath = regexp.MustCompile(`^gno\.land\/(?:p|r)(?:\/_?[a-z]+[a-z0-9_]*)+$`) | ||
| rePkgOrRlmOrStdlibPath = regexp.MustCompile(`^gno\.land\/(?:p|r)(?:\/_?[a-z]+[a-z0-9_]*)+|(?:[a-z]+[a-z0-9_]*)(?:\/_?[a-z]+[a-z0-9_]*)*$`) |
There was a problem hiding this comment.
What do you think about breaking up this regex?
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
|
@n0izn0iz |
|
It passes There has been a recent change in gnodev that require an update on my side, I still need to address that I would love some feedback on the direction it's taking |
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Summoning @thehowl :) |
WIP opening for discussions
Closes #2730
Depends on #3119
TODO:
MsgAddPackageor introduceMsgAddStdlib(see this comment) -> Going for keepingMsgAddPackagefor nowgno fmtgno docgnogenesisContributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description