refactor: r/demo/users
#3166
Open
refactor: r/demo/users
#3166
+1,528
−1,618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
🧾 package/realm
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
github-actions
bot
added
📦 🤖 gnovm
# Conflicts: # examples/gno.land/r/demo/users/users.gno # examples/gno.land/r/demo/users/z_10_filetest.gno # examples/gno.land/r/demo/users/z_11_filetest.gno # examples/gno.land/r/demo/users/z_11b_filetest.gno # examples/gno.land/r/demo/users/z_2_filetest.gno # examples/gno.land/r/demo/users/z_3_filetest.gno # examples/gno.land/r/demo/users/z_4_filetest.gno # examples/gno.land/r/demo/users/z_5_filetest.gno # examples/gno.land/r/demo/users/z_6_filetest.gno # examples/gno.land/r/demo/users/z_7_filetest.gno # examples/gno.land/r/demo/users/z_7b_filetest.gno # examples/gno.land/r/demo/users/z_8_filetest.gno # examples/gno.land/r/demo/users/z_9_filetest.gno # examples/gno.land/r/sys/users/verify.gno
|
Ready for review, apart from some unrelated failing txtars, and the gno lint issue. Fixing txtars, but opening up for reviews. Do I need to update what TODO:
|
|
Regarding govdao bridge deployment order. We’ll maybe change the pattern, but with the current one, deployment order should be fixed dimly by having a proposal contract that import both the bridge and v1 impl and register it. This way it will be done automatically during block 0 with no risk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses: #2827
This PR refactors the current
r/demo/users&r/sys/userssystem in accordance to the issue mentioned above. Below is the high-level overview.r/gnoland/users/v1r/demo/usersr/sys/usersMainnet v1 (mvp) & v2 #2827r/demo/profilefor displaying extra information about a userr/sys/usersr/sys/namesr/gnoland/users/v1, etc. Whitelist is managed by an ownable objectr/gov/dao/bridge#3523 is resolved so that GovDAO can be the sole owner of the realm, and can manage the whitelist & pausabilityr/sys/namesKeeperr/sys/namesfor the namespace check instead ofr/sys/usersr/gnoland/users/v1Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description