-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gnorkle): Add periodic feed #2847
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job. I think this is a great start. One question I have is -- is this supposed to be used as a feed for a VRF? I think that this is fine for a generic implementation for a periodic feed and a multistream ingester, but to me is seems that a VRF would have something more similar to what could be described as a continuous feed. There would be no "periods" defined by the feed and no "committing" of values by the ingester; instead each call to retrieve a value would perform an aggregation on the data in the ingester's store buffer, producing a pseudo-random string or integer value. Right now it is just joining strings together for each period, so each value obtained would remain the same for each period. A continuous feed would make it possible to produce a different value at every block, or even produce different values within the same block depending on the transactions in the block and their contents.
This PR is stale because it has been open 3 months with no activity. Remove stale label or comment or this will be closed in 3 months. |
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
This PR implements add a few features into the gnorkle p/demo/examples realms:
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description