From 1d6b937dc00d85c99cd95afa9faf40a76269c7c1 Mon Sep 17 00:00:00 2001 From: Stephen Rosen Date: Tue, 17 Dec 2024 14:27:36 -0600 Subject: [PATCH] Bugfix: allow_domains vs allowed_domains I've confirmed with the team that this was always incorrect -- there was never a version which accepted `allow_domains`. --- .../20241217_142634_sirosen_fix_sgw_allowed_domains.rst | 6 ++++++ src/globus_sdk/services/gcs/data/storage_gateway.py | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 changelog.d/20241217_142634_sirosen_fix_sgw_allowed_domains.rst diff --git a/changelog.d/20241217_142634_sirosen_fix_sgw_allowed_domains.rst b/changelog.d/20241217_142634_sirosen_fix_sgw_allowed_domains.rst new file mode 100644 index 000000000..14320d3ef --- /dev/null +++ b/changelog.d/20241217_142634_sirosen_fix_sgw_allowed_domains.rst @@ -0,0 +1,6 @@ +Fixed +~~~~~ + +- Fix a bug in ``StorageGatewayDocument`` which stored any ``allowed_domains`` + argument under an ``"allow_domains"`` key instead of the correct key, + ``"allowed_domains"``. (:pr:`NUMBER`) diff --git a/src/globus_sdk/services/gcs/data/storage_gateway.py b/src/globus_sdk/services/gcs/data/storage_gateway.py index 6c96cb797..4d27a121f 100644 --- a/src/globus_sdk/services/gcs/data/storage_gateway.py +++ b/src/globus_sdk/services/gcs/data/storage_gateway.py @@ -78,7 +78,7 @@ def __init__( root=root, ) self._set_optstrlists( - allow_domains=allowed_domains, + allowed_domains=allowed_domains, users_allow=users_allow, users_deny=users_deny, )