Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure doesn't show as failure #2691

Open
TWiStErRob opened this issue Jan 14, 2025 · 1 comment
Open

Failure doesn't show as failure #2691

TWiStErRob opened this issue Jan 14, 2025 · 1 comment

Comments

@TWiStErRob
Copy link

TWiStErRob commented Jan 14, 2025 •
edited
Loading

We have a step that uses upload-sarif. It ran on merge_group: but failed because the merge queue item was removed from the queue. This resulted in the following error message (which seems normal, branch is deleted by removal from queue):

Image

Notice that somehow the step is still shown as successful, and yet the step failed because the next step had a condition to run if it failed. I'm wondering if there's something missing from the upload-sarif to make the "Publish" step red cross too, or this is maybe a GHA UI glitch.
@redsun82
Copy link
Contributor

That indeed does seem weird. Could you maybe chime in @shaikhul?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@redsun82 @TWiStErRob