Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Delete PR staging and head branches" workflow fails for PR merges by 'advisory-database' bot #5167

Open
Marcono1234 opened this issue Jan 14, 2025 · 0 comments

Comments

@Marcono1234
Copy link
Contributor

Marcono1234 commented Jan 14, 2025

The "Delete PR staging and head branches" (.github/workflows/delete_staging_and_head_branches.yaml) workflow currently fails when a PR was merged by the 'advisory-database' bot, because that bot is already deleting the source branch itself.
This might be a bit irritating when viewing the "Checks" tab of a pull request, or when you see the ❌ indicator for the commit of the pull request.

See for example https://github.com/github/advisory-database/actions/runs/12750406199 for #4588.

Maybe the solution could be that the 'advisory-database' bot is changed to not delete the branch itself?
Removing the "Delete PR staging and head branches" workflow is probably not an option because it is needed for pull requests closed by the author (and not merged), and adding || true or similar in the workflow might hide actual errors when deleting branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant