Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode doesn't work when using non-standard themes like "Adw-Dark" instead of Adwaita #878

Closed
DebanjanBarman opened this issue Apr 3, 2022 · 7 comments
Labels
invalid Not a bug, or not caused by GTG.

Comments

@DebanjanBarman
Copy link

Dark mode isn't working
Screenshot from 2022-04-03 08-48-25
.

@kocio-pl
Copy link
Contributor

kocio-pl commented Apr 3, 2022

Try to change system style and give a reply what happens. I have dark style in my system and I have the opposite problem - GTG is always dark, no matter what are the application settings.

@daniel-sanchez-marzoa
Copy link

Hi, had the same problem but I already have dark style in my system, and gtg is still light

@Neui
Copy link
Contributor

Neui commented Apr 8, 2022

What distribution do you use? Do you use some custom style? Try executing GTG with GTK_DEBUG=interactive (like GTK_DEBUG=interactive flatpak run org.gnome.GTG for the flatpak version, GTK_DEBUG=interactive gtg for a locally installed version), and check the Visual tab in the new window.

It should tell you the GTK3 theme (where you can also switch) and whenever darkmode is enabled. Note that the Dark Mode in GTG settings should change that dark mode settings in visual tab, but not the other way around.

Here is me trying it out GTG (flatpak) on Fedora 36 beta live CD in a VM:
GTG dark mode test in fedora 36 beta

@Chrysostomus
Copy link

I ran into the same issue on Manjaro with the flatpak version. I think I have identified the issue: the gtk-theme we are using is Adw-dark that mimics the libadwaita theme. This makes regular gtk3 apps look like libadwaita apps, but because the corresponing flatpak theme is not installed, gtg does not know what to do and the gtk theme in interactive debugging is unset.

The solution is to install the corresponding flatpak theme.

@daniel-sanchez-marzoa
Copy link

I can confirm it was a problem with the theme I was using in Gnome. Switching back to the default Adwaita-dark fixed the problem. Thanks for the help

@Nesaijn
Copy link

Nesaijn commented Oct 3, 2022

I had the same reason for this issue. The entry in the "Visual" tab for "GTK+ Theme" was empty since I did set another theme in gnome tweaks for legacy applications. Setting it to "Adwaita" fixed it.

An idea to fix this is to set "Adwaita" as a default for the entry "GTK+ Theme" for cases like these.

EDIT:
Another workaround or fix as the already mentioned ones for the Flatpak version, is setting the GTK_THEME environment for GTG, for example in Flatseal. GTK_THEME=Adwaita did not work as it always used the light version so GTK_THEME=Adwaita:dark was the way to go for me.

@nekohayo nekohayo added the invalid Not a bug, or not caused by GTG. label Feb 27, 2024
@nekohayo nekohayo changed the title Dark Mode doesn't work Dark Mode doesn't work when using non-standard themes like "Adw-Dark" instead of Adwaita Feb 27, 2024
@nekohayo
Copy link
Member

Closing as you folks found a workaround for your custom theme problem.

In the long term, the solution for this would be #608 (including #576 + #844).

@nekohayo nekohayo closed this as not planned Won't fix, can't repro, duplicate, stale Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Not a bug, or not caused by GTG.
Projects
None yet
Development

No branches or pull requests

7 participants