New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing electron peer dependency #10

Open

guillaumearm opened this issue Sep 4, 2018 · 1 comment

Contributor

guillaumearm commented Sep 4, 2018 •

edited

Loading

We should add electron compatible version range in peerDependencies

"peerDependencies": { "electron": ">=1.7.1 <=2.02" }

Additionally it can be a good thing to add [email protected] in devDependencies to fix unit tests.

The text was updated successfully, but these errors were encountered:

grantcv1 commented Apr 26, 2019

The peer dependencies are now set to:

"peerDependencies": {
"electron": ">=17.1 <3.x.x"
},

It seems it should read >=1.7.1 rather than >=17.1 and it would be really helpful if the other end could be upgraded to <6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment