-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add_string_variable
removed
#154
Comments
let mut reim = file.add_variable_with_type("reim", &["reim"], &netcdf::types::NcVariableType::String)?;
reim.put_attribute("long_name", "Complex")?;
reim.put_string("real", 0)?;
reim.put_string("imaginary", 1)?; |
This seems regressive, what's the motivation for not having the convenience constructor? |
This was removed at the same time as support for user-defined types were added. It felt redundant at the time to have so many constructors |
I also was confused by the removal of this function, especially without a changelog to see recommended migrations. Personally, I find that string variables are common enough that the convenience constructor is worthwhile (compared to, say, vlen types). But, if the decision is to simplify the number of constructors, then an example should be added to the documentation. For me, I would look for that example either at the top of the crate (with the other simple examples) or in the |
I'm updating my project to your recent version that utilizes the fork of HDF5, but am running into an error that
add_string_variable
has been removed. I don't see a changelog, and a cursory look around doesn't indicate an obvious replacement.Before I had something like:
which now doesn't work. Any help would be appreciated.
The text was updated successfully, but these errors were encountered: