Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depreciated constant in HA 2025.1.0 breaks integration #634

Open
johnwilson1969 opened this issue Jan 3, 2025 · 11 comments
Open

Depreciated constant in HA 2025.1.0 breaks integration #634

johnwilson1969 opened this issue Jan 3, 2025 · 11 comments
Labels
bug Something isn't working

Comments

@johnwilson1969
Copy link

johnwilson1969 commented Jan 3, 2025

HA core version

2025.1.0

Intergration version

0.3.22

Device type and model

Dehumidifier

Used App

Home Assistant

The description of problem

I have the same issue covered under the umbrella of "unable to start after update to 2025.1.0" but a different error message:

Setup failed for custom integration 'midea_ac_lan': Unable to import component: cannot import name 'TIME_DAYS' from 'homeassistant.const' (/usr/src/homeassistant/homeassistant/const.py)

This seems to be due to TIME_DAYS being depreciated - notes in the source code says:

"""Deprecated: please use UnitOfTime.DAYS."""

EDIT: These and possibly others are all used in the integration and have been decreciated to new constants

TIME_DAYS
TIME_HOURS
TIME_MINUTES
TIME_SECONDS

EDIT 2: Seems like all have been updated to new values with the exception of PERCENTAGE

The logs

Logger: homeassistant.setup
Source: setup.py:334
First occurred: 5:40:21 PM (1 occurrences)
Last logged: 5:40:21 PM

Setup failed for custom integration 'midea_ac_lan': Unable to import component: cannot import name 'TIME_DAYS' from 'homeassistant.const' (/usr/src/homeassistant/homeassistant/const.py)
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/loader.py", line 1015, in async_get_component
comp = await self.hass.async_add_import_executor_job(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
self._get_component, True
^^^^^^^^^^^^^^^^^^^^^^^^^
)
^
File "/usr/local/lib/python3.13/concurrent/futures/thread.py", line 59, in run
result = self.fn(*self.args, **self.kwargs)
File "/usr/src/homeassistant/homeassistant/loader.py", line 1075, in _get_component
ComponentProtocol, importlib.import_module(self.pkg_path)
~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/util/loop.py", line 200, in protected_loop_func
return func(*args, **kwargs)
File "/usr/local/lib/python3.13/importlib/init.py", line 88, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "", line 1387, in _gcd_import
File "", line 1360, in _find_and_load
File "", line 1331, in _find_and_load_unlocked
File "", line 935, in _load_unlocked
File "", line 1026, in exec_module
File "", line 488, in _call_with_frames_removed
File "/config/custom_components/midea_ac_lan/init.py", line 17, in
from .midea_devices import MIDEA_DEVICES
File "/config/custom_components/midea_ac_lan/midea_devices.py", line 1, in
from homeassistant.const import (
...<12 lines>...
)
ImportError: cannot import name 'TIME_DAYS' from 'homeassistant.const' (/usr/src/homeassistant/homeassistant/const.py)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/setup.py", line 334, in _async_setup_component
component = await integration.async_get_component()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/loader.py", line 1035, in async_get_component
self._component_future.result()
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
File "/usr/src/homeassistant/homeassistant/loader.py", line 1027, in async_get_component
comp = self._get_component()
File "/usr/src/homeassistant/homeassistant/loader.py", line 1075, in _get_component
ComponentProtocol, importlib.import_module(self.pkg_path)
~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/util/loop.py", line 200, in protected_loop_func
return func(*args, **kwargs)
File "/usr/local/lib/python3.13/importlib/init.py", line 88, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "", line 1387, in _gcd_import
File "", line 1360, in _find_and_load
File "", line 1331, in _find_and_load_unlocked
File "", line 935, in _load_unlocked
File "", line 1026, in exec_module
File "", line 488, in _call_with_frames_removed
File "/config/custom_components/midea_ac_lan/init.py", line 17, in
from .midea_devices import MIDEA_DEVICES
File "/config/custom_components/midea_ac_lan/midea_devices.py", line 1, in
from homeassistant.const import (
...<12 lines>...
)
ImportError: cannot import name 'TIME_DAYS' from 'homeassistant.const' (/usr/src/homeassistant/homeassistant/const.py)

@johnwilson1969 johnwilson1969 added the bug Something isn't working label Jan 3, 2025
@pauloon
Copy link

pauloon commented Jan 4, 2025

I'm having the same here. Will be waiting for a fix.
Thanks for reporting.

@fangming828
Copy link

我这里也遇到了同样的问题。请大佬修复。
谢谢。

@jesterod
Copy link

jesterod commented Jan 4, 2025

Same issue had to downgrade HA core

@vergil-zhao
Copy link

Just submitted a fix PR, you can also replace all deprecated constants by yourself. Changes in the PR above.

@ThemeIT
Copy link

ThemeIT commented Jan 4, 2025

Your PR works like a charm, thanks :)

@pcmike
Copy link

pcmike commented Jan 4, 2025

Same, waiting for this update to go live

@superpower10
Copy link

So we wait for a HACS Midea update? Right?

@deenx
Copy link

deenx commented Jan 4, 2025

same here after update HA 2025.1.0

@ThemeIT
Copy link

ThemeIT commented Jan 4, 2025

So we wait for a HACS Midea update? Right?

i would suggest updating your local copy of the repo through a HA file editor.

All necessary updates can be seen here: 3bd4cf1

Just add the changes to your local files to: /homeassistant/custom_components/midea_ac_lan/... (and there are 3 python files to be changed)

I have a gut feeling that this PR will be unanswered for quite some time as the repos original maintainer seems to be absent

also you could use this guide -> #635 (comment)

@mf76130
Copy link

mf76130 commented Jan 5, 2025

just went through it to correct mine, seems there are these 2 not changed:
CONCENTRATION_MICROGRAMS_PER_CUBIC_METER,
CONCENTRATION_PARTS_PER_MILLION
and cause an error.
Trying to figure out what to change them to.

Edit: In the meanwhile i just imported the files via terminal and now it doesn't care about these constants anymore!

thanks a lot for the work

@erikgieseler
Copy link

This reporistory is dead because the maintainer has not been available for a long time and no more pull requests are being merged. You should switch to https://github.com/wuwentao/midea_ac_lan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests