Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add muon tools and tests #5872

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Add muon tools and tests #5872

wants to merge 18 commits into from

Conversation

ivelet
Copy link
Contributor

@ivelet ivelet commented Mar 15, 2024

FOR CONTRIBUTOR:

  • [x ] - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • [x ] - License permits unrestricted use (educational + commercial)
  • [ x] - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

@@ -0,0 +1,87 @@
<tool id="assign_cell_type_labels_mudata" name="Assign Cell Type Labels for MuData" version="0.1.0">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a profile version.

Suggested change
<tool id="assign_cell_type_labels_mudata" name="Assign Cell Type Labels for MuData" version="0.1.0">
<tool id="assign_cell_type_labels_mudata" name="Assign Cell Type Labels for MuData" version="0.1.0" profile="22.05">

]]></configfile>
</configfiles>
<inputs>
<param name="rna_atac_input" type="data" format="h5mu" label="RNA ATAC Data Matrix"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be a Galaxy datatype. What is h5mu? N normal hdf5 format?

<inputs>
<param name="mudata_input" type="data" format="h5mu" label="MuData input file to run processing" help="(.h5mu)"/>
<conditional name="method">
<param argument="method" type="select" label="Method used for processing">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here is something off with the alignment of text, please try https://github.com/galaxyproject/galaxy-language-server this can also reformat your file automatically ...

@pavanvidem
Copy link
Member

This was an old work from @ivelet. Please do not review it already. I will fix this in the next weeks.

@pavanvidem
Copy link
Member

@ivelet please mark this as ready to review

@ivelet ivelet marked this pull request as ready for review January 16, 2025 15:37
@bgruening bgruening changed the title Add muon tools and tests [WIP] Add muon tools and tests Jan 17, 2025
<param argument="random_state" type="integer" value="@SEED@" optional="true" label="Random seed for the optimization"/>
</xml>
<xml name="param_key_added" tokens="key_added">
<param argument="key_added" type="text" value="@KEY_ADDED@" label="mdata.obs key where cluster labels to be added"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavanvidem we do have in other tools a validator for keys do we?

If specified, look for .obsp[.uns[neighbors_key]['connectivities_key']] in each modality for connectivities."/>
</xml>
<xml name="param_directed">
<param argument="directed" type="boolean" truevalue="True" falsevalue="False" checked="true" label="Treat the graph as directed or undirected"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The label does not indicate if true means directed or undirected I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants